Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes metrics config option required in app_insights #20406

Merged
merged 9 commits into from
Aug 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 3, 2020

What does this PR do?

Makes metrics config option required.

Why is it important?

Validation

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 3, 2020
@narph narph changed the title App config Makes metrics config option required in app_insights Aug 3, 2020
@narph narph self-assigned this Aug 3, 2020
@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Aug 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 3, 2020
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 3, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20406 updated]

  • Start Time: 2020-08-04T10:27:19.873+0000

  • Duration: 62 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 3525
Skipped 818
Total 4343

@narph narph merged commit 496e3c9 into elastic:master Aug 4, 2020
@narph narph deleted the app-config branch August 4, 2020 11:52
narph added a commit to narph/beats that referenced this pull request Aug 4, 2020
* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt

(cherry picked from commit 496e3c9)
narph added a commit to narph/beats that referenced this pull request Aug 4, 2020
* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt

(cherry picked from commit 496e3c9)
narph added a commit that referenced this pull request Aug 4, 2020
* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt

(cherry picked from commit 496e3c9)
narph added a commit that referenced this pull request Aug 4, 2020
* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt

(cherry picked from commit 496e3c9)
v1v added a commit to v1v/beats that referenced this pull request Aug 6, 2020
…ne-2.0

* upstream/master:
  [docs] Promote ingest management to beta (elastic#20295)
  Upgrade elasticsearch client library used in tests (elastic#20405)
  Disable logging when pulling on python integration tests (elastic#20397)
  Remove pillow from testing requirements.txt (elastic#20407)
  [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440)
  [Ingest Manager] Send datastreams fields (elastic#20402)
  Add event.ingested to all Filebeat modules (elastic#20386)
  [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426)
  Improve cgroup_regex docs with examples (elastic#20425)
  Makes `metrics` config option required in app_insights (elastic#20406)
  Ensure install scripts only install if needed (elastic#20349)
  Update container name for the azure filesets (elastic#19899)
  Group same timestamp metrics values in app_insights metricset (elastic#20403)
  add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767)
  Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547)
  [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396)
  Update Suricata dashboards (elastic#20394)
  [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359)
  Prepare home directories for docker images in a different stage (elastic#20356)
v1v added a commit to v1v/beats that referenced this pull request Aug 6, 2020
…allation

* upstream/master: (23 commits)
  [docs] Promote ingest management to beta (elastic#20295)
  Upgrade elasticsearch client library used in tests (elastic#20405)
  Disable logging when pulling on python integration tests (elastic#20397)
  Remove pillow from testing requirements.txt (elastic#20407)
  [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440)
  [Ingest Manager] Send datastreams fields (elastic#20402)
  Add event.ingested to all Filebeat modules (elastic#20386)
  [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426)
  Improve cgroup_regex docs with examples (elastic#20425)
  Makes `metrics` config option required in app_insights (elastic#20406)
  Ensure install scripts only install if needed (elastic#20349)
  Update container name for the azure filesets (elastic#19899)
  Group same timestamp metrics values in app_insights metricset (elastic#20403)
  add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767)
  Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547)
  [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396)
  Update Suricata dashboards (elastic#20394)
  [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359)
  Prepare home directories for docker images in a different stage (elastic#20356)
  New multiline mode in Filebeat: while_pattern (elastic#19662)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
elastic#20424)

* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt

(cherry picked from commit a14cac5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants